Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows for the Farihold calculation to happen in the API. See #69
Before this PR
The API
route.ts
used to fetch the data and pass it to the frontend. Then, the Fairhold calculations used to happen in the frontend.Now
The API
route.ts
also computes the Fairhold calculations, and it returns the results to the frontend.Side issue/fix
I think that there was mismatch in how we were dealing with
socialRentAdjustements
. Specifically:socialRentAdjustmentsRepo.ts
was converting the data into string || nullWithin socialRentAdjustmentsRepo.ts I deleted the conversion to
string
and set up a clause guard to check fornull
.Not sure if that's the best approach